[PATCH] D153992: AMDGPU: Avoid computing dominator tree for printf lowering

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 11:47:05 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:505
+  auto GetDT = [&FAM](Function &F) -> DominatorTree * {
+    return FAM.getCachedResult<DominatorTreeAnalysis>(F);
   };
----------------
Cached analyses on the NewPM should only be used for analyses preservation. You should either require DT here or not use it at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153992/new/

https://reviews.llvm.org/D153992



More information about the llvm-commits mailing list