[PATCH] D146776: Reland [llvm] Preliminary fat-lto-objects support

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 11:15:05 PDT 2023


aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp:51
+
+  return PreservedAnalyses::all();
+}
----------------
paulkirth wrote:
> Is there another option we can use here. `none` seems like overkill. Since this is basically the first thing to run on the module, I'm not sure if there is much point in trying to do anything smarter, but it certainly doesn't feel right.
perhaps something like https://reviews.llvm.org/D153855?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776



More information about the llvm-commits mailing list