[PATCH] D149889: [TTI] Use users of GEP to guess access type in getGEPCost

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 10:37:35 PDT 2023


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/required changes.

In addition to the inline code comment, make sure you update your commit message.  The current review description is out of sync with the code and you must fix that before landing.



================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:4972
       return getGEPCost(BaseGEP->getSourceElementType(),
-                        BaseGEP->getPointerOperand(), Indices, CostKind);
     }
----------------
Pass nullptr here so that you don't change the x86 behavior.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149889/new/

https://reviews.llvm.org/D149889



More information about the llvm-commits mailing list