[PATCH] D153904: [instrprof] Add an overload to accept raw_string_ostream.

Wed Jun 28 09:51:59 PDT 2023

tejohnson added a comment.

In D153904#4456676 <https://reviews.llvm.org/D153904#4456676>, @snehasish wrote:

> In D153904#4456647 <https://reviews.llvm.org/D153904#4456647>, @snehasish wrote:
>
>> In D153904#4456588 <https://reviews.llvm.org/D153904#4456588>, @tejohnson wrote:
>>
>>> LGTM but please change description per your explanation
>>
>> Hmm, I amended the commit message in my branch but after landing it I don't see it in git log. Let me try to fix up.
>
> Fixing up now (after other commits have landed on top of this one) is too risky without a revert and restore. Let me know if you feel strongly about updating the message.

It's fine as is then, the explanation is here in the patch if anyone is curious.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153904/new/

https://reviews.llvm.org/D153904