[PATCH] D152115: [X86] Add tests for transform `(icmp eq/ne (and X, C0), (shift X, C1))`; NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 09:30:53 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/cmp-shiftX-maskX.ll:5
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+sse2 | FileCheck %s --check-prefixes=CHECK,CHECK-NOBMI,CHECK-NOBMI-SSE2
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+bmi2,+sse2 | FileCheck %s --check-prefixes=CHECK,CHECK-BMI2,CHECK-BMI2-SSE2
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+bmi2,+avx2 | FileCheck %s --check-prefixes=CHECK,CHECK-BMI2,CHECK-AVX2
----------------
Sorry - miscommunication, SSE2 is implicit in the bmi2 targets on line 3 - you just need to add a CHECK-BMI2-SSE2 to it, and drop the duplicate -mattr=+bmi2,+sse2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152115/new/

https://reviews.llvm.org/D152115



More information about the llvm-commits mailing list