[PATCH] D151035: [OpenMP][OpenMPIRBuilder] Migrate kernel launch code and host fallback code generation from Clang to the OpenMPIRBuilder

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9588
+  if (OffloadingMandatory) {
+    CGF.Builder.CreateUnreachable();
+  } else {
----------------
jdoerfert wrote:
> Unrelated but I feel we should at least emit a trap. This feels user hostile and there is nothing we can really optimize here.
There's a codegen option to emit unreachable as trap


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151035/new/

https://reviews.llvm.org/D151035