[PATCH] D153904: [instrprof] Add an overload to accept raw_string_ostream.

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 08:56:02 PDT 2023


snehasish added a comment.

In D153904#4454737 <https://reviews.llvm.org/D153904#4454737>, @tejohnson wrote:

> The change looks fine to me but is this patch missing the referenced unit test changes?:
>
>> Also use this new overload for existing unit test usecases.

Sorry, my wording wasn't clear. By changing L658 in InstrProfWriter.cpp to use the new overload (in writeBuffer), all the unit tests now implicitly call the new overload.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153904/new/

https://reviews.llvm.org/D153904



More information about the llvm-commits mailing list