[PATCH] D153879: [AMDGPU] Handle Additional Cases in tryFoldPhiAGPR

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fold-agpr-phis.mir:505
+  bb.2:
+    S_ENDPGM 0
+...
----------------
Pierre-vh wrote:
> arsenm wrote:
> > Could also use and end to end IR test
> I don't have one; I can try reducing the original app's code but that may take a while, the kernel is big.
> 
> I tried reproducing the pattern I thought was relevant using some functions from mfma_loop but I can't get it to create that two copy pattern. I will try digging a bit more, but is a end-to-end test necessary here?
I'd like an end to end test because eventually all this code should be deleted but we should preserve the copy-avoiding behavior. In the ideal future RegBankSelect would take care of this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153879/new/

https://reviews.llvm.org/D153879