[PATCH] D152258: [LV] Add mask support for vectorizing interleaved groups
Graham Hunter via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 07:53:12 PDT 2023
huntergr accepted this revision.
huntergr added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2688
+ Intrinsic::experimental_vector_interleave2,
+ Ops, nullptr, "interleaved.mask");
+ }
----------------
Nit: when passing a null or boolean literal into a function, it's customary in LLVM to add an inline comment before it indicating the parameter name, as below.
`/*FMFSource=*/nullptr` would work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152258/new/
https://reviews.llvm.org/D152258
More information about the llvm-commits
mailing list