[PATCH] D149715: IR: Add llvm.frexp intrinsic

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2332
+                                          SDValue &Lo, SDValue &Hi) {
+  // Get the dest types - they may not match the input types, e.g. int_to_fp.
+  EVT LoVT, HiVT;
----------------
The comment looks not suitable.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2336
+  SDLoc dl(N);
+  std::tie(LoVT, HiVT) = DAG.GetSplitDestVTs(N->getValueType(0));
+  std::tie(LoVT1, HiVT1) = DAG.GetSplitDestVTs(N->getValueType(1));
----------------
You could use C++17 feature here:

    auto [LoVT, HiVT] = DAG.GetSplitDestVTs(N->getValueType(0));


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149715/new/

https://reviews.llvm.org/D149715