[PATCH] D153967: [lit] Remove the --no-indirectly-run-check option

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 06:18:30 PDT 2023


ldionne created this revision.
ldionne added reviewers: yln, jdenny.
Herald added a subscriber: delcypher.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This option had originally been added in D83069 <https://reviews.llvm.org/D83069> to allow disabling the
check that something is going to get run at all when a specific test name
is used on the command-line. Since we now use getTestsForPath() (from D151664 <https://reviews.llvm.org/D151664>)
to get the tests to run for a specific path, we don't need a specific check
for this anymore -- Lit will produce the same complaint it would produce if
you provided a directory with no tests.

If one needs to run a specific test on the command-line and the Lit
configuration would normally not include that test, the configuration
should be set up as a "standalone" configuration or it should be fixed
to allow for that test to be found (i.e. probably fix the allowed test
suffixes).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153967

Files:
  llvm/docs/CommandGuide/lit.rst
  llvm/utils/lit/lit/LitTestCase.py
  llvm/utils/lit/lit/cl_arguments.py
  llvm/utils/lit/lit/discovery.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/discovery.py
  llvm/utils/lit/tests/unit/TestRunner.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153967.535361.patch
Type: text/x-patch
Size: 7949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230628/8cbc34e0/attachment.bin>


More information about the llvm-commits mailing list