[PATCH] D151799: [ConstraintElim] Try to use first cmp to prove second cmp for ANDs.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:1010
+                                          unsigned NumIn, unsigned NumOut,
+                                          Instruction *ContextInst) {
   LLVM_DEBUG(dbgs() << "Checking " << *Cmp << "\n");
----------------
nikic wrote:
> Commit this refactoring separately?
Split off to 4b47711ae2ed16014a1b34fb5b4270f5572fd72e 


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:1130
+    else
+      And->setOperand(1, ConstantInt::getFalse(And->getType()));
+    Changed = true;
----------------
nikic wrote:
> Use `ConstantInt::getBool()`?
Updated, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151799/new/

https://reviews.llvm.org/D151799