[PATCH] D152276: [DAGCombine] Fold (store (insert_elt (load p)) x p) -> (store x)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 03:31:29 PDT 2023


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - we just need to clear up whether fixed-vectors-insert.ll needs tweaking



================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-insert.ll:8
 
 define void @insertelt_v4i64(ptr %x, i64 %y) {
 ; RV32-LABEL: insertelt_v4i64:
----------------
luke wrote:
> This might be obscuring the behaviour of the actual insert_vector_elt codegen. Let me know if I should mark these stores as volatile
@craig.topper Any thoughts on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152276/new/

https://reviews.llvm.org/D152276



More information about the llvm-commits mailing list