[PATCH] D153948: [RISCV][NFC] Refactor lowerToScalableOp.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan marked 3 inline comments as done.
jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4625
+bool RISCVTargetLowering::hasMergeOp(unsigned Opcode) const {
+  assert(Opcode > RISCVISD::FIRST_NUMBER &&
+         Opcode <= RISCVISD::STRICT_VFROUND_NOEXCEPT_VL && "not a valid op");
----------------
frasercrmck wrote:
> I wonder if we want stronger checks here so people don't insert an op in the wrong place and have weird stuff happen.
change to `report_fatal_error`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153948/new/

https://reviews.llvm.org/D153948