[PATCH] D152358: [CGP] Remove operand of llvm.assume more aggressively.

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 01:58:17 PDT 2023


skatkov added a comment.

In D152358#4454950 <https://reviews.llvm.org/D152358#4454950>, @nikic wrote:

> Our longer term plan was to stop removing assumes in CGP, so they remain available during codegen, in particular for AA purposes. Instead, we would drop assumes more aggressively earlier if they keep control flow alive.
>
> It seems pretty likely that assumes that keep alive otherwise dead IVs are also blocking optimizations in earlier parts of the pipeline, and we would be better of dropping such assumes earlier. I'm not entirely sure what the right heuristic for that would be, but "ephemeral values of the assume include a phi node" is probably a pretty good one.

The current stage: remove but not everything looks the worst way. In my understanding, let's remove all the dead code together or keep it alive.
So I propose to land this up to the point CGP get rid of this code.

What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152358/new/

https://reviews.llvm.org/D152358



More information about the llvm-commits mailing list