[PATCH] D153072: [lsan] Be more conservative in SuspendedThreadsListMac::GetRegistersAndSP

[Hans Wennborg via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fd517d6133e: [lsan] Be more conservative in SuspendedThreadsListMac::GetRegistersAndSP (authored by lgrey, committed by hans).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153072/new/

https://reviews.llvm.org/D153072

Files:
  compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp


Index: compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
===================================================================
--- compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
+++ compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
@@ -154,12 +154,10 @@
                          &reg_count);
   if (err != KERN_SUCCESS) {
     VReport(1, "Error - unable to get registers for a thread\n");
-    // KERN_INVALID_ARGUMENT indicates that either the flavor is invalid,
-    // or the thread does not exist. The other possible error case,
     // MIG_ARRAY_TOO_LARGE, means that the state is too large, but it's
     // still safe to proceed.
-    return err == KERN_INVALID_ARGUMENT ? REGISTERS_UNAVAILABLE_FATAL
-                                        : REGISTERS_UNAVAILABLE;
+    return err == MIG_ARRAY_TOO_LARGE ? REGISTERS_UNAVAILABLE
+                                      : REGISTERS_UNAVAILABLE_FATAL;
   }
 
   buffer->resize(RoundUpTo(sizeof(regs), sizeof(uptr)) / sizeof(uptr));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153072.535286.patch
Type: text/x-patch
Size: 1031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230628/88eb4b29/attachment.bin>