[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

Wed Jun 28 00:47:54 PDT 2023

michaelplatings added a comment.

In D153430#4453908 <https://reviews.llvm.org/D153430#4453908>, @MaskRay wrote:

> Thank you for implementing this warning. Side note: it would be better to (a) fix the tests separately from (b) implementing the warning and (c) adding tests to demonstrate the warning.
> This way the patch is more focused.

Agreed, it would have been better to fix the tests first in a separate patch.

In D153430#4454371 <https://reviews.llvm.org/D153430#4454371>, @alexfh wrote:

> After the patch, LLVM still has a number of `aarch64-arm-none-eabi` usages in tests, which is also considered invalid now: https://gcc.godbolt.org/z/z8cY5j68M

Huh. I have no idea why they didn't come up in my find-and-replace. Thanks @MaskRay for fixing. I found some more: D153943 <https://reviews.llvm.org/D153943>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153430/new/

https://reviews.llvm.org/D153430