[PATCH] D153927: Resubmit: [NFC] Refactor MBB hotness/coldness into templated PSI functions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 00:27:04 PDT 2023


MaskRay added a comment.

Apologies but I am going to revert this patch. There is a layering violation (https://llvm.org/docs/CodingStandards.html#library-layering). LLVMAnalysis cannot depend on LLVMCodeGen.

  llvm/include/llvm/Analysis/ProfileSummaryInfo.h:19:10: fatal error: 'llvm/CodeGen/MachineFunction.h' file not found
     19 | #include "llvm/CodeGen/MachineFunction.h"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153927/new/

https://reviews.llvm.org/D153927



More information about the llvm-commits mailing list