[PATCH] D143762: [AMDGPU] Enable whole wave register copy

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 00:02:16 PDT 2023


yassingh updated this revision to Diff 535253.
yassingh added a comment.

Review commnets and remove pass from O0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143762/new/

https://reviews.llvm.org/D143762

Files:
  llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp


Index: llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
+++ llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 //
 /// \file
-/// Lowering the WWM_COPY instructions for various register classes. 
+/// Lowering the WWM_COPY instructions for various register classes.
 /// AMDGPU target generates WWM_COPY instruction to differentiate WWM
 /// copy from COPY. This pass generates the necessary exec mask manipulation
 /// instructions to replicate 'Whole Wave Mode' and lowers WWM_COPY back to
@@ -40,9 +40,7 @@
 
   bool runOnMachineFunction(MachineFunction &MF) override;
 
-  StringRef getPassName() const override {
-    return "SI Lower WWM Copies";
-  }
+  StringRef getPassName() const override { return "SI Lower WWM Copies"; }
 
   void getAnalysisUsage(AnalysisUsage &AU) const override {
     AU.setPreservesAll();
@@ -63,12 +61,12 @@
 
 } // End anonymous namespace.
 
-INITIALIZE_PASS_BEGIN(SILowerWWMCopies, DEBUG_TYPE,
-                      "SI Lower WWM Copies", false, false)
+INITIALIZE_PASS_BEGIN(SILowerWWMCopies, DEBUG_TYPE, "SI Lower WWM Copies",
+                      false, false)
 INITIALIZE_PASS_DEPENDENCY(LiveIntervals)
 INITIALIZE_PASS_DEPENDENCY(VirtRegMap)
-INITIALIZE_PASS_END(SILowerWWMCopies, DEBUG_TYPE,
-                    "SI Lower WWM Copies", false, false)
+INITIALIZE_PASS_END(SILowerWWMCopies, DEBUG_TYPE, "SI Lower WWM Copies", false,
+                    false)
 
 char SILowerWWMCopies::ID = 0;
 
@@ -88,8 +86,7 @@
 
 // If \p Reg is assigned with a physical VGPR, add the latter into wwm-spills
 // for preserving its entire lanes at function prolog/epilog.
-void SILowerWWMCopies::addToWWMSpills(MachineFunction &MF,
-                                             Register Reg) {
+void SILowerWWMCopies::addToWWMSpills(MachineFunction &MF, Register Reg) {
   if (Reg.isPhysical())
     return;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143762.535253.patch
Type: text/x-patch
Size: 2045 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230628/6ddd3930/attachment.bin>


More information about the llvm-commits mailing list