[PATCH] D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

This is cool!



================
Comment at: llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h:283
+
   unsigned FileID, ExpandedFileID;
   unsigned LineStart, ColumnStart, LineEnd, ColumnEnd;
----------------
On AArch64 Darwin (with clang-1403), `FileID` is set to 1 when used uninitialised. Somewhere in this patch set we create a default `CounterMappingRegion` struct.

This causes `ParameterizedCovMapTest/CoverageMappingTest.non_code_region_bitmask/0` to assert.

Can we explicitly initialise these values to 0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138847/new/

https://reviews.llvm.org/D138847