[PATCH] D142879: [RISCV] Emit relocation for uleb128

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:33
+static cl::opt<bool>
+    EnableULEB128Reloc("riscv-enable-uleb128", cl::init(false), cl::Hidden,
+                       cl::desc("Enable relocation emission for ULEB128."));
----------------
MaskRay wrote:
> 
The intention of this option is considering the binutils compatibility, binuilts has support that on trunk which will be part of binutils 2.41, but it's still not release yet.

Anyway personally I don't have strong opinion on the default value of this option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142879/new/

https://reviews.llvm.org/D142879