[PATCH] D153820: [CSSPGO][Preinliner] Always inline zero-sized functions.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 16:54:53 PDT 2023


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: llvm/tools/llvm-profgen/CSPreInliner.h:47-48
+    // only pseudo probes are left.
+    if (LHS.SizeCost == 0 || RHS.SizeCost == 0) {
+      if (LHS.SizeCost != RHS.SizeCost)
+        return RHS.SizeCost == 0;
----------------
nit: merge the two ifs into a single line?

```
if ((LHS.SizeCost == 0 || RHS.SizeCost == 0) && LHS.SizeCost != RHS.SizeCost)
    return return RHS.SizeCost == 0;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153820/new/

https://reviews.llvm.org/D153820



More information about the llvm-commits mailing list