[PATCH] D153930: [unittest] teach gTest to print entries of DenseMap as pairs

[Sam McCall via Phabricator via llvm-commits]

sammccall created this revision.
sammccall added reviewers: mboehme, labath.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When an assertion like the following fails:

  EXPECT_THAT(map, ElementsAre(Pair("p", "nullable"))));

Error message before:

  Actual: { 40-byte object <E8-A5 9C-7F 25-37 00-00 58-7E 51-51 D0-7F 00-00 00-00 00-00 00-00 00-00 01-00 00-00 00-00 00-00 00-DA C7-7F 25-37 00-00> }

After:

  Actual: { ("p", "nonnull") }

It is not ideal that we need to refer directly to DenseMapPair inside the
internal namespace, but I believe the practical maintenance risk is low.
This change is covered by DenseMap's unittests, as we've covered SmallString etc
in the past.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153930

Files:
  llvm/unittests/ADT/DenseMapTest.cpp
  third-party/unittest/googletest/include/gtest/internal/custom/gtest-printers.h


Index: third-party/unittest/googletest/include/gtest/internal/custom/gtest-printers.h
===================================================================
--- third-party/unittest/googletest/include/gtest/internal/custom/gtest-printers.h
+++ third-party/unittest/googletest/include/gtest/internal/custom/gtest-printers.h
@@ -39,6 +39,7 @@
 #ifndef GTEST_INCLUDE_GTEST_INTERNAL_CUSTOM_GTEST_PRINTERS_H_
 #define GTEST_INCLUDE_GTEST_INTERNAL_CUSTOM_GTEST_PRINTERS_H_
 
+#include "llvm/ADT/DenseMap.h"
 #if !GTEST_NO_LLVM_SUPPORT
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringRef.h"
@@ -63,6 +64,17 @@
 inline void PrintTo(const SmallVectorImpl<char> &S, std::ostream *OS) {
   *OS << ::testing::PrintToString(std::string(S.data(), S.size()));
 }
+
+// DenseMap's entries inherit from std::pair, and should act like pairs.
+// However gTest's provided `PrintTo(pair<K,V>)` template won't deduce K and V
+// because of the needed derived-to-base conversion.
+namespace detail {
+template <typename K, typename V>
+inline void PrintTo(const DenseMapPair<K, V> &Pair, std::ostream *OS) {
+  *OS << ::testing::PrintToString(static_cast<const std::pair<K, V> &>(Pair));
+}
+} // namespace detail
+
 } // namespace llvm
 #endif // !GTEST_NO_LLVM_SUPPORT
 
Index: llvm/unittests/ADT/DenseMapTest.cpp
===================================================================
--- llvm/unittests/ADT/DenseMapTest.cpp
+++ llvm/unittests/ADT/DenseMapTest.cpp
@@ -9,6 +9,7 @@
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/DenseMapInfo.h"
 #include "llvm/ADT/DenseMapInfoVariant.h"
+#include "llvm/ADT/StringRef.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 #include <map>
@@ -756,4 +757,12 @@
   // operator==.
   EXPECT_FALSE(DenseMapInfo<variant>::isEqual(Keys[2], Keys[2]));
 }
+
+// Test that gTest prints map entries as pairs instead of opaque objects.
+// See third-party/unittest/googletest/internal/custom/gtest-printers.h
+TEST(DenseMapCustomTest, PairPrinting) {
+  DenseMap<int, StringRef> Map = {{1, "one"}, {2, "two"}};
+  EXPECT_EQ(R"({ (1, "one"), (2, "two") })", ::testing::PrintToString(Map));
+}
+
 } // namespace


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153930.535184.patch
Type: text/x-patch
Size: 2140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230627/31edf706/attachment-0001.bin>