[PATCH] D130105: [NFC][AMDGPU] Refactor AMDGPUDisassembler

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-sgpr.s:7
 ;; Only set next_free_sgpr.
-.amdhsa_kernel my_kernel_1
+; RUN: llvm-mc --triple=amdgcn-amd-amdhsa -mattr=-xnack -filetype=obj -mcpu=gfx908 <1.s >1.o
+; RUN: llvm-objdump --disassemble-symbols=kernel.kd 1.o | tail -n +7 | tee 1-disasm.s | FileCheck 1.s
----------------
`<1.s` => `< 1.s`. The same applies to `>1.o`


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-sgpr.s:10
+; RUN: llvm-mc --triple=amdgcn-amd-amdhsa -mattr=-xnack -filetype=obj -mcpu=gfx908 <1-disasm.s >1-disasm.o
+; RUN: diff 1.o 1-disasm.o
+; CHECK: .amdhsa_kernel kernel
----------------
Use `cmp` for binary blobs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130105/new/

https://reviews.llvm.org/D130105