[PATCH] D153771: [BOLT][Instrumentation] Fix hash table memory corruption and append-pid option

Denis Revunov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 15:01:23 PDT 2023


treapster added a comment.

In D153771#4453993 <https://reviews.llvm.org/D153771#4453993>, @rafauler wrote:

> 



> Manually adding the PIE load address in instr.cpp:readDescription() might or might not be easier.

The main issue here is we'll have either map the whole BinContents as RW, or memcpy just descriptions to another writeble region. Then just loop over entries and patch. Sounds a bit easier than messing with JITLink, though. Another solution may be to just extract the base address every time inside lookupIndCallTarget.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153771/new/

https://reviews.llvm.org/D153771



More information about the llvm-commits mailing list