[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

Tue Jun 27 13:52:54 PDT 2023

MaskRay added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:2921
   MarshallingInfoStringVector<CodeGenOpts<"PassPlugins">>;
+def mtocdata_EQ : CommaJoined<["-"], "mtocdata=">,
+  Flags<[CoreOption, CC1Option]>,
----------------
alexgatea wrote:
> MaskRay wrote:
> > Make sure AIX-specific options have `TargetSpecific` flag.
> These are not meant to be target-specific to AIX. It's just that this patch only implements setTargetAttributes on AIX; on other platforms we would like these options to simply be ignored.
TOC is PowerPC specific so `TargetSpecific` is still applicable.

CoreOption is only needed if you want to support Windows clang-cl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153907/new/

https://reviews.llvm.org/D153907