[PATCH] D153872: [LoongArch] Emit R_LARCH_64_PCREL relocation for FK_Data_8 when IsPCRel is true

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Some nits about the test



================
Comment at: llvm/test/MC/LoongArch/Relocations/sub-expr.s:8
+
+.section sx
+x:
----------------
Better to make `sx` and `sy` SHF_ALLOC by using `"a"`


================
Comment at: llvm/test/MC/LoongArch/Relocations/sub-expr.s:13
+.data
+.8byte x-.   # CHECK: 0x0 R_LARCH_64_PCREL sx 0x0
+.8byte y-.   # CHECK: 0x8 R_LARCH_64_PCREL sy 0x0
----------------
Changing these from inline comments to non-inline comments should be cleaner.

Add `-NEXT` and surround them with a pair of `CHECK: .rela .data {`  and `CHECK-NEXT: }` to test that there is no additional relocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153872/new/

https://reviews.llvm.org/D153872