[PATCH] D153406: [Attributor] Convert test to opaque pointers

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/arg-count-mismatch.ll:46
 ; CGSCC-SAME: (i16 [[A:%.*]]) #[[ATTR0:[0-9]+]] {
-; CGSCC-NEXT:    [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar to i16 (i16)*)(i16 [[A]])
+; CGSCC-NEXT:    [[CALL:%.*]] = call noundef i16 @bar() #[[ATTR3:[0-9]+]]
 ; CGSCC-NEXT:    ret i16 [[CALL]]
----------------
nikic wrote:
> We now infer attributes despite the mismatch in signature. That looks fine here, but possibly it only works by accident.
It's fine to deduce correct attributes. We should not do sth wrong or crash. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153406/new/

https://reviews.llvm.org/D153406