[PATCH] D152945: [SystemZ][z/OS] Implement executePostLayoutBinding for GOFFWriter

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 08:15:24 PDT 2023


DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/GOFFObjectWriter.cpp:937
+          Data.append(1, B);
+          I++;
+          if (I == MaxChunkSize) {
----------------
kpn wrote:
> DiggerLin wrote:
> > change to ++I;
> Is this a documented standard? Because pre- and post- are widely used in the codebase.
https://llvm.org/docs/CodingStandards.html#prefer-preincrement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152945/new/

https://reviews.llvm.org/D152945



More information about the llvm-commits mailing list