[PATCH] D153771: [BOLT][Instrumentation] Fix hash table memory corruption and append-pid option

Tue Jun 27 07:19:43 PDT 2023

treapster added a comment.

In D153771#4452452 <https://reviews.llvm.org/D153771#4452452>, @treapster wrote:

> Turns out, the [unknown] entries in profile are because addresses in indirect call descriptions are not relocated, which makes them meaningless in PIE because of ASLR. When the test is compiled with no-pie, indirect calls are recorded accurately. So, we should either compute base address and add it to stored entries, or produce dynamic relocations.

But since .bolt.instr.tables is not loadable, the only option is to perform relocation by hand. BTW, why isn't it loadable?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153771/new/

https://reviews.llvm.org/D153771