[PATCH] D153865: [LoongArch] Add back SDNPSideEffect properties to CSR and IOCSR read ops
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 06:37:09 PDT 2023
xen0n added a comment.
In D153865#4452309 <https://reviews.llvm.org/D153865#4452309>, @xry111 wrote:
> Ah, in the C standard "reading a volatile variable" is indeed a side effect. I must have been thinking about another definition of "side effect".
>
> But should we do it for movfcsr2gr as well? It cannot be reordered with any floating-point arithmetic instructions.
Ah indeed. There are Flags and Cause fields that are effectively, flag bits. FCSR reads should be free of side-effects but reordering indeed should get inhibited, I think it's probably better to deal with that in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153865/new/
https://reviews.llvm.org/D153865
More information about the llvm-commits
mailing list