[PATCH] D153394: [AArch64][GlobalISel] Selection support for v2s16 G_ANYEXT

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 05:48:06 PDT 2023


Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:420
                         .getReg(0);
-              } else {
+              } else if (OldVT.isInteger() && NewVT.isInteger()) {
                 // Just do a vector extend.
----------------
tschuett wrote:
> tschuett wrote:
> > Could you instead query OldLLT and NewLLT whether they are `isScalar()`? Looks odd to query MVTs in GISel.
> It is about integer and floats?
Yes, It is about integer and floats (not about the scalar and vector).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153394/new/

https://reviews.llvm.org/D153394



More information about the llvm-commits mailing list