[PATCH] D153758: [AMDGPU] Use GlobalISel MatchTable Combiner Backend

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 05:38:38 PDT 2023


Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:22-23
 #include "llvm/CodeGen/GlobalISel/CombinerInfo.h"
+#include "llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h"
+#include "llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h"
 #include "llvm/CodeGen/GlobalISel/GISelKnownBits.h"
----------------
Some small detail I'm unsure about: Should I put these in the `GET_GICOMBINER_DEPS` and also do a typedef of `GIMatchTableExecutor` to something like `ClassNameBase` ? That way users don't even need to know about the match table executor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153758/new/

https://reviews.llvm.org/D153758



More information about the llvm-commits mailing list