[PATCH] D144534: [DAGCombine] Fold SETCC_OEQ(x, Inf) into IS_FPCLASS

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fp-classify.ll:616
+; SI-NEXT:    v_cvt_f32_f16_e64 v1, |s0|
+; SI-NEXT:    v_cmp_class_f32_e32 vcc, v1, v0
 ; SI-NEXT:    v_cndmask_b32_e64 v0, 0, 1, vcc
----------------
arsenm wrote:
> The result is the same but I’d somewhat prefer to keep the original isa. The infinity constant is more likely reusable with other uses in the program 
Fpclass checks are be better if the constant is used one or more times only in such comparison, I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144534/new/

https://reviews.llvm.org/D144534