[PATCH] D153838: [MCP] Optimize copies from undef

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 02:42:19 PDT 2023


Pierre-vh added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:486-487
+  if (!CopyOperands->Source->isUndef()) {
+    PrevCopy->getOperand(PrevCopyOperands->Source->getOperandNo())
+        .setIsUndef(false);
+  }
----------------
foad wrote:
> Doesn't `PrevCopyOperands->Source->setIsUndef(false)` work?
The reference to the MachineOperand is const, unfortunately


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153838/new/

https://reviews.llvm.org/D153838



More information about the llvm-commits mailing list