[PATCH] D134600: [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation
Xinlong Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 02:30:24 PDT 2023
VincentWu marked an inline comment as not done.
VincentWu added a comment.
================
Comment at: lld/ELF/Arch/RISCV.cpp:1226
+ return;
+ isFinalized = true;
+
----------------
jrtc27 wrote:
> We call finalizeContents more than once?
This method will be called at the end of the last round of relaxation. the `changed` in `Writer<ELFT>::finalizeAddressDependentContent()` might be set as `true`, which will cause the linker to do an additional relaxation. the code here is just try to avoiding it being called again in an additional relaxation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134600/new/
https://reviews.llvm.org/D134600
More information about the llvm-commits
mailing list