[PATCH] D153843: [AMDGPU] Add more Common Feature Sets

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 01:53:34 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM assuming it's NFC.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1240
      FeatureSupportsXNACK,
-     FeatureBackOffBarrier])>;
+     // GFX 101x Bugs
+     FeatureVcmpxPermlaneHazard,
----------------
Nit: I would either spell this gfx101x (like an -mcpu= value) or GFX 10.1.x (like an architecture name).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153843/new/

https://reviews.llvm.org/D153843



More information about the llvm-commits mailing list