[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 00:04:32 PDT 2023
jhenderson added a comment.
The updated unit test is failing on Windows in the pre-merge checks. Please investigate and fix as appropriate.
================
Comment at: llvm/unittests/Support/raw_ostream_test.cpp:500
+ ASSERT_TRUE(!!Perms);
+ EXPECT_EQ(0, *Perms & llvm::sys::fs::all_exe);
+
----------------
Here and below, rather than just checking the all_exe bit, let's check the permissions are exactly what are expected (e.g. does it have the read/write perms?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153652/new/
https://reviews.llvm.org/D153652
More information about the llvm-commits
mailing list