[PATCH] D153316: [AArch64][SelectionDAG] fix infinite loop caused by legalizing & combining CONCAT_VECTORS

[FLZ via Phabricator via llvm-commits]

FLZ101 added a comment.

In D153316#4448220 <https://reviews.llvm.org/D153316#4448220>, @RKSimon wrote:

> LGTM - cheers

Thanks



================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-concat-vectors.ll:1
+; RUN: llc -mtriple=aarch64 -mattr=+sve < %s | FileCheck %s
+
----------------
MaskRay wrote:
> Run `PATH=$build_dir/bin:$PATH llvm-project/llvm/utils/update_llc_test_checks.py dag-combine-concat-vectors.ll` to regenerate this test.
> 
> https://maskray.me/blog/2021-08-08-toolchain-testing "A regression test which simply runs the compiler and expects it not to crash has low utilization. It is often better to additionally test some properties of the produced object file."
> 
> The comment can be simplified:
> 
> > Test that we do not end in an infinite loop https://github.com/llvm/llvm-project/issues/63322
Very helpful. Thanks


================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-concat-vectors.ll:1
+; RUN: llc -mtriple=aarch64 -mattr=+sve < %s | FileCheck %s
+
----------------
FLZ101 wrote:
> MaskRay wrote:
> > Run `PATH=$build_dir/bin:$PATH llvm-project/llvm/utils/update_llc_test_checks.py dag-combine-concat-vectors.ll` to regenerate this test.
> > 
> > https://maskray.me/blog/2021-08-08-toolchain-testing "A regression test which simply runs the compiler and expects it not to crash has low utilization. It is often better to additionally test some properties of the produced object file."
> > 
> > The comment can be simplified:
> > 
> > > Test that we do not end in an infinite loop https://github.com/llvm/llvm-project/issues/63322
> Very helpful. Thanks
> Run `PATH=$build_dir/bin:$PATH llvm-project/llvm/utils/update_llc_test_checks.py dag-combine-concat-vectors.ll` to regenerate this test.
> 
> https://maskray.me/blog/2021-08-08-toolchain-testing "A regression test which simply runs the compiler and expects it not to crash has low utilization. It is often better to additionally test some properties of the produced object file."
> 
> The comment can be simplified:
> 
> > Test that we do not end in an infinite loop https://github.com/llvm/llvm-project/issues/63322




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153316/new/

https://reviews.llvm.org/D153316