[PATCH] D152758: [NFC] Refactor MBB hotness/coldness into templated PSI functions

Han Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 21:06:40 PDT 2023


shenhan marked an inline comment as done.
shenhan added a comment.

Thanks @wenlei for the review.



================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:127
   /// Returns true if \p F contains hot code.
-  bool isFunctionHotInCallGraph(const Function *F,
-                                BlockFrequencyInfo &BFI) const;
+  template <typename FunctionType, typename BFIT>
+  bool isFunctionHotInCallGraph(const FunctionType *F, BFIT &BFI) const {
----------------
wenlei wrote:
> nit: FunctionType->FuncT to be consistent with BFIT and other template definitions. 
> 
> 
Done for all occurrences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152758/new/

https://reviews.llvm.org/D152758



More information about the llvm-commits mailing list