[PATCH] D153821: [Symbolizer] Ignroe unknown additional symbolizer markup fields

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr accepted this revision.
mcgrathr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp:136
       filterNode(Node);
-    highlight();
-    OS << "[[[reset]]]" << lineEnding();
-    restoreColor();
+    printRawElement(Node);
+    OS << lineEnding();
----------------
I don't know of a reason to print anything at all when a reset element is encountered.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-reset.test:24
 
 {{{reset:}}}
+{{{module:0:a.o:elf:ab}}}
----------------
A trailing colon is an odd case, though I see no reason not to accept it. But it's never what an expected future extension would look like. Probably the test should cover `reset:this=1:that`, etc.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153821/new/

https://reviews.llvm.org/D153821