[PATCH] D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64
Rafael Auler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 26 17:15:39 PDT 2023
rafauler added inline comments.
================
Comment at: bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp:1407
+ Insts.emplace_back();
+ createPushRegisters(Insts.back(), TempReg, AArch64::X1);
+ Insts.emplace_back(CallInst);
----------------
Why not X0, X1 directly here? Doesn't look like X0 is a temporary register, btw, so I think the naming of "TempReg" is a bit off here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151899/new/
https://reviews.llvm.org/D151899
More information about the llvm-commits
mailing list