[PATCH] D153167: [MC] Reject CFI advance_loc separated by a non-private label for Mach-O

Mon Jun 26 14:24:00 PDT 2023

MaskRay added a comment.

In D153167#4450248 <https://reviews.llvm.org/D153167#4450248>, @efriedma wrote:

> LGTM
>
> We could consider adding an SMLoc field to MCDwarfCallFrameFragment; other fragments have a location field (for similar reasons, I assume).  But that doesn't need to block this fix.

Thank you! 
To get SMLoc, I think we'll need to change functions like `llvm/include/llvm/MC/MCDwarf.h:createAdjustCfaOffset` and `FrameEmitterImpl::emitCFIInstructions`, quite a few changes.
I'll need to investigate this area more to prepare for `--gsframe` support...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153167/new/

https://reviews.llvm.org/D153167