[PATCH] D153679: [LegacyPM] Remove RewriteSymbolsLegacyPass

Mon Jun 26 13:10:10 PDT 2023

nikic added a comment.

In D153679#4450135 <https://reviews.llvm.org/D153679#4450135>, @srj wrote:

> In D153679#4450033 <https://reviews.llvm.org/D153679#4450033>, @nikic wrote:
>
>> @srj Could you please share how you're currently using the pass? It's possible we just have to revert this, but hard to say without code.
>
> See the function `emit_file` here: https://github.com/halide/Halide/blob/main/src/LLVM_Output.cpp#L341

Thanks! You could run just that one pass separately with the NewPM, but that probably doesn't make a lot of sense.

I think we should revert this change for now and keep the pass until we have NewPM support for the codegen pipeline. @aeubanks What do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153679/new/

https://reviews.llvm.org/D153679