[PATCH] D150428: [flang][openmp] Allocators construct semantic checks

[Ethan Luis McDonough via Phabricator via llvm-commits]

elmcdonough added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:2034
+            [&](const parser::Name &n) {
+              CheckNameInAllocateStmt(source, n, allocate);
+            },
----------------
kiranchandramohan wrote:
> Please add a test that exercises this path (Commonblocks?).
Removed this because I can't think of a scenario where a common block name would appear in an allocation list.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:2054
+  context_.Say(source,
+      "Object '%s' in %s directive not "
+      "found in corresponding ALLOCATE statement"_err_en_US,
----------------
kiranchandramohan wrote:
> Is this currently only called for the `allocate` in `allocators`?
For now, but I was planning on adding it to D150483 to cover the `List items specified in an allocate directive that is associated with an allocate statement must be variables that are allocated by the allocate statement` semantic requirement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150428/new/

https://reviews.llvm.org/D150428