[PATCH] D153550: [DWARFVerifier] Fix verification of nameless variables.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 11:07:52 PDT 2023


dblaikie added a comment.

In D153550#4448765 <https://reviews.llvm.org/D153550#4448765>, @fdeazeve wrote:

> In D153550#4441881 <https://reviews.llvm.org/D153550#4441881>, @dblaikie wrote:
>
>> But maybe the deeper question: Why are we creating DW_AT_variables for string literals? They aren't variables as far as a user would be concerned. GCC doesn't do this...
>
> @dblaikie apparently this was done last year: https://reviews.llvm.org/D123534

ah, right... - thanks for the reference! & then, yeah, just not putting these things in the index seems good. (even if we did revisit the original decision to include this debug info unconditionally - adding it under a flag, etc, we'd still want to fix the index issue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153550/new/

https://reviews.llvm.org/D153550



More information about the llvm-commits mailing list