[PATCH] D143762: [AMDGPU] Enable whole wave register copy

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:8004
+  if (MFI->checkFlag(SrcReg, AMDGPU::VirtRegFlag::WWM_REG))
+    return AMDGPU::PRED_COPY;
+
----------------
I guess the name is wrong now. It's technically an unpredicated copy. Rename to WWM_COPY or COPY_WWM?


================
Comment at: llvm/lib/Target/AMDGPU/SILowerPredicatedCopies.cpp:82
+bool SILowerPredicatedCopies::isWWMCopy(const MachineInstr &MI,
+                                        const TargetInstrInfo &TII) {
+  // Skip if it is a subreg copy.
----------------
SIInstrInfo


================
Comment at: llvm/lib/Target/AMDGPU/SILowerPredicatedCopies.cpp:92
+
+  if (SrcReg.isPhysical())
+    return false;
----------------
Either this check is unnecessary or should have happened earlier to avoid crashing on the checkFlag


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143762/new/

https://reviews.llvm.org/D143762