[PATCH] D149445: [MachineInst] Switch NumOperands to 16bits
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 26 10:42:34 PDT 2023
jroelofs added a comment.
In D149445#4446238 <https://reviews.llvm.org/D149445#4446238>, @barannikov88 wrote:
> In D149445#4441593 <https://reviews.llvm.org/D149445#4441593>, @jroelofs wrote:
>
>> This change broke the build for an internal project of ours (breadcrumb: rdar://109362033). The relevant code being compiled is a fairly large nested switch that results in a PHI node with 65k+ operands, which can't easily be turned into a table for perf reasons.
>>
>> WDYT about making it the lower 24 bits of a `uint32_t` bitfield shared with `AsmPrinterFlags` in the upper 8?
>
> Sounds fine to me
https://reviews.llvm.org/D153791
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149445/new/
https://reviews.llvm.org/D149445
More information about the llvm-commits
mailing list