[PATCH] D153791: [MachineInst] Bump NumOperands back up to 24bits

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 10:42:17 PDT 2023


jroelofs created this revision.
jroelofs added reviewers: nikic, xbolva00, barannikov88, craig.topper.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
jroelofs requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In https://reviews.llvm.org/D149445, it was lowered from 32 to 16bits, which broke an internal project of ours. The relevant code being compiled is a fairly large nested switch that results in a PHI node with 65k+ operands, which can't easily be turned into a table for perf reasons.

      

This change unifies `NumOperands`, `Flags`, and `AsmPrinterFlags` into a packed 7-byte struct, which `CapOperands` can follow as the 8th byte, rounding it up to a nice alignment before the `Info` field.

      

rdar://111217742&109362033


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153791

Files:
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/lib/CodeGen/MachineInstr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153791.534638.patch
Type: text/x-patch
Size: 7616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230626/f25e18ff/attachment.bin>


More information about the llvm-commits mailing list