[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

[Alison Zhang via Phabricator via llvm-commits]

azhan92 added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:1312
+                               Twine("cannot not open file '") + FName +
+                                   "': Is a directory");
+    }
----------------
hubert.reinterpretcast wrote:
> azhan92 wrote:
> > hubert.reinterpretcast wrote:
> > > @azhan92, how was the string (`"': Is a directory"`) determined in terms of the text and capitalization? I ask because `strerror` on different platforms may return different text (for example, may include message catalogue numbers or use different capitalization).
> > I used that string because that's the message used on Linux, and also what this lit test expects (https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/response-file-errs.c). 
> @azhan92, for consistency, please use the `message()` from the `error_code`.
> For example, z/OS generates: `EDC5123I Is a directory.`
> 
Sorry, I replied to your comment awhile ago but I forgot to submit it. I determined this string based off this lit test (https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/response-file-errs.c) as well as the failing external bot failure (https://lab.llvm.org/buildbot/#/builders/214/builds/8134/steps/6/logs/FAIL__LLVM__input-file-err_test) since they both expect '{{.*}}Inputs': {{[Ii]}}s a directory 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151567/new/

https://reviews.llvm.org/D151567